Fix thread naming error during fail-fast validation when connector name is null #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@KGaneshDatta We might need temporary placeholders for these values for cases where null could appear, instead of falling back to other required configuration. Please take that into consideration. |
airlock-confluentinc
bot
force-pushed
the
v3.0.8-hotfix-x
branch
from
073fb66 to
f7edb12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connector thread naming pattern uses placeholders for ${connector.name} and ${task.id} which can be null during fail-fast validation on Confluent Cloud, causing the
error: "Cannot invoke 'java.lang.CharSequence.toString()' because 'replacement' is null".This PR adds proper null handling by using the topic prefix as a fallback when connector name is null, preventing the exception during connection validation without changing the intended naming behavior.