Skip to content

Synchronize release 1.19 changes over master branch #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uilianries merged 15 commits into from
Oct 8, 2025
Merged

Synchronize release 1.19 changes over master branch #49

uilianries merged 15 commits into from
Oct 8, 2025

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Oct 8, 2025

Description of your Pull Request

Merge change done in the release 1.19 into master branch

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've tested locally that my code works.
  • I've added relevant tests to verify that my code works.

@uilianries
Mark 1.19 as stable version
e75df28 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Add workflow to validate patch-ng with Conan
62e6c5f 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Install Conan requirements for testing
7017512 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Add CCI validation
b2f05c2 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Refer repo in a separte folder
3a1db14 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Move test script
e9986ed 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Try to fix test script path
3ee94b7 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Exclude recipe with system requirements
173c5d5 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Trigger CI
6f1d4cb 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Support a few non patch related errors
ff7b15c 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Allow missing binaries as an error
a1a060e 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Fix condition
1cac875 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Exclude conans import
274c01e 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Update allowed errors
e07cb8b 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Fix quoted file paths
50fcd3b 
Signed-off-by: Uilian Ries <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 8, 2025
View reviewed changes
.github/workflows/conan-center-index.yml
Comment on lines +24 to +47
name: "Validate Patche-NG in Conan Center Index"
runs-on: ubuntu-22.04
steps:
- name: Checkout repository
uses: actions/checkout@v5
with:
path: python-ng

- name: Setup Conan client
uses: conan-io/setup-conan@v1

- name: Setup Python NG
run: pip install -e ./python-ng

- name: Checkout conan-center-index
uses: actions/checkout@v5
with:
repository: conan-io/conan-center-index
path: conan-center-index
ref: 'd8efbb6f3c51b134205f01d3f8d90bdad1a67fe6'

- name: Validate Python-NG patch application
working-directory: conan-center-index/recipes
run: bash "${GITHUB_WORKSPACE}/python-ng/.github/scripts/validate-cci-patch-ng.sh"

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
.github/workflows/conan.yml
Comment on lines +24 to +48
name: "Validate Conan client"
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v5

- name: Setup python
uses: actions/setup-python@v6
with:
python-version: 3.12
architecture: x64

- name: Clone conan client
run: |
git clone --depth 1 https://github.com/conan-io/conan.git
cd conan/
pip install -r conans/requirements_dev.txt
pip install -r conans/requirements.txt

- name: Run Conan client tests involving patch-ng
run: |
pip install -e .
cd conan/
pytest -v test/functional/test_third_party_patch_flow.py
pytest -v test/functional/tools/test_files.py
pytest -v test/unittests/tools/files/test_patches.py

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 2 months ago

To fix this problem, explicitly define the minimum required permissions using a permissions block. Since this workflow only runs checks, installs dependencies, and executes tests—it does not appear to require write access—contents: read is usually the minimal necessary permission for these CI jobs. The permissions block can be added either at the top (root) level so it applies globally to all jobs, or per job for more granular control. Adding it at the root is sufficient here. To implement, insert the following directly after the name: Validate Conan client line and before the on: block in .github/workflows/conan.yml:

permissions:
  contents: read

No additional packages or methods need to be added.

Suggested changeset 1
.github/workflows/conan.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/conan.yml b/.github/workflows/conan.yml
--- a/.github/workflows/conan.yml
+++ b/.github/workflows/conan.yml
@@ -1,4 +1,6 @@
 name: Validate Conan client
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Validate Conan client
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@uilianries uilianries merged commit 78bc675 into master Oct 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uilianries