docs: Expand notes on concurrent mutations and following symlinks#453
Merged
Conversation
The default of follow_symlinks(true) was in retrospect a mistake, but one hard to fix now (without a semver bump, which we'll do at some point).k This was reported as a private security issue by @thesmartshadow but we cannot change things for compatibility reasons here - any security issues related to this must be reported against projects *using* tar-rs. Assisted-by: OpenCode (Claude Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
Adds a crate-level `# Security` section to `lib.rs` that draws a clear boundary: path traversal and symlink validation within the archive are in scope; concurrent mutation of the destination tree by another process (e.g. atomically swapping a symlink to redirect writes out of `dst`) is explicitly outside the threat model without something like `cap-std`. Per-function Security sections on `Archive::unpack`, `Entry::unpack_in`, and `Entry::unpack` are collapsed to pointers to the canonical crate-level doc, avoiding duplication. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.