selabel: Break hardlinks when different SELinux labels are assigned#296
Open
cgwalters wants to merge 1 commit into
Open
selabel: Break hardlinks when different SELinux labels are assigned#296cgwalters wants to merge 1 commit into
cgwalters wants to merge 1 commit into
Conversation
When two filesystem paths are hardlinked (share the same LeafId in the in-memory tree) but the SELinux policy assigns them different labels, we had "last looked at wins" behavior. This conflict between hardlinks and SELinux has come up many times (it bit me badly in bootc when trying to have the binary also be a systemd generator, so we ended up with a helper shell script). Fix this by just breaking the hardlink, which is also what OSTree does. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two filesystem paths are hardlinked (share the same LeafId in the in-memory tree) but the SELinux policy assigns them different labels, we had "last looked at wins" behavior.
This conflict between hardlinks and SELinux has come up many times (it bit me badly in bootc when trying to have the binary also be
a systemd generator, so we ended up with a helper shell script).
Fix this by just breaking the hardlink, which is also what OSTree does.
Assisted-by: OpenCode (claude-sonnet-4-6@default)