fix(upload): Preserve UploadActivity state across screen resize/split-screen #6565
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
nicolas-raoul
approved these changes
Nov 23, 2025
Member
nicolas-raoul
left a comment
nicolas-raoul
left a comment
There was a problem hiding this comment.
I was finally able to trigger a crash (though with a slightly different stack trace) by following the screencast and making Commons' area tiny.
This change solves that crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5784
What changes did you make and why?
The
UploadActivitywas previously being destroyed and recreated (restarted) when the user resized the application window, such as when entering or exiting split-screen mode. This caused the app to lose the current upload fragment state and return to the application's home screen.smallestScreenSizeandscreenLayoutto theandroid:configChangesattribute forUploadActivityinAndroidManifest.xml. This instructs the Android system to notify the activity of these configuration changes instead of fully restarting it, thereby preserving the user's progress through the upload flow.Tests performed
Tested
ProdDebugonRedmi note 13 pro 5gwith API level35.