Skip to content

Fix kotling warnings for Image.kt and Folder.kt (part of Issue #5996) #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2025
Merged

Fix kotling warnings for Image.kt and Folder.kt (part of Issue #5996) #6441

merged 3 commits into from
Oct 5, 2025

Conversation

benshung
Copy link
Contributor

@benshung benshung commented Oct 3, 2025

Hi, this is my first PR on Issue #5996

Changes made:

  • Fixed warning that 'equals() and hashCode() not paired' for Image.kt and Folder.kt
  • Fixed deprecation warning for readParcelable() function in Image.kt

Tested betaDebug on Medium Phone with API level 35 and 31.

No UI Changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2025

✅ Generated APK variants!

nicolas-raoul
nicolas-raoul approved these changes Oct 5, 2025
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nicolas-raoul nicolas-raoul merged commit 6bc25cc into commons-app:main Oct 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benshung @nicolas-raoul