Repository navigation
revert grapheme-counter.js separated entry - #139
Conversation
|
commit: |
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 9 -2
Lines 1005 940 -65
=========================================
- Hits 1005 940 -65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Added in #135, unreleased.
I've changed my mind. It doesn't need to be complicated with multiple entries, since they are small enough and well compressed.
And importantly, most users use only the
countGraphemesAPI for its exact purpose, or reuse the memoized generator result as I guided in the README earlier. It's a distinguishable use case.To deliver appropriate performance rewards to projects that use only the
countGraphemesAPI, I must upgrade the existing path rather than adding a new entry for it.I'll upgrade the existing
countGraphemesAPI in the next follow-up PR.