Skip to content

revert grapheme-counter.js separated entry - #139

Merged
cometkim merged 4 commits into
mainfrom
revert-counter-api
Jul 22, 2026
Merged

cometkim merged 4 commits into
mainfrom
revert-counter-api

Conversation

@cometkim

Copy link
Copy Markdown
Owner

Added in #135, unreleased.

I've changed my mind. It doesn't need to be complicated with multiple entries, since they are small enough and well compressed.

And importantly, most users use only the countGraphemes API for its exact purpose, or reuse the memoized generator result as I guided in the README earlier. It's a distinguishable use case.

To deliver appropriate performance rewards to projects that use only the countGraphemes API, I must upgrade the existing path rather than adding a new entry for it.

I'll upgrade the existing countGraphemes API in the next follow-up PR.

@changeset-bot

changeset-bot Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a43e3e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/unicode-segmenter@139

commit: a43e3e7

@codspeed

codspeed Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 12 skipped benchmarks1


Comparing revert-counter-api (a43e3e7) with main (21a2c68)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cometkim
cometkim merged commit 2ac327c into main Jul 22, 2026
3 checks passed
@cometkim
cometkim deleted the revert-counter-api branch July 22, 2026 08:00
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (21a2c68) to head (a43e3e7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11         9    -2     
  Lines         1005       940   -65     
=========================================
- Hits          1005       940   -65     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant