refactor(account): remove unused v1 module after ISA-2025-003 fix#124
Closed
kitay-sudo wants to merge 1 commit into
Closed
refactor(account): remove unused v1 module after ISA-2025-003 fix#124kitay-sudo wants to merge 1 commit into
kitay-sudo wants to merge 1 commit into
Conversation
The try_from_type_and_bytes function in account::v1 is no longer needed since the address validation now uses Id::from(PublicKey) directly. This simplifies the code and removes duplication. Closes #107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
account::v1module after the ISA-2025-003 security fix.Changes
account::v1::try_from_type_and_bytes()withId::from(PublicKey)in validator.rspub mod v1from account.rsRelated
Closes #107
Note
Removes
account::v1and updates v1 validator conversions to validate addresses viaId::from(pub_key)with corresponding import adjustments.cometbft/src/account.rs):pub mod v1and itstry_from_type_and_byteshelper.cometbft/src/validator.rs):addressby deriving from parsedpub_keyusingId::from(pub_key).crate::account::Id.Written by Cursor Bugbot for commit 45f18a4. This will update automatically on new commits. Configure here.