Skip to content

feat(rpc): add kvstore fixtures for v1#118

Open
melekes wants to merge 1 commit into
mainfrom
rpc-kvstore-v1
Open

feat(rpc): add kvstore fixtures for v1#118
melekes wants to merge 1 commit into
mainfrom
rpc-kvstore-v1

Conversation

@melekes
Copy link
Copy Markdown
Collaborator

@melekes melekes commented Jun 30, 2025

This pull request introduces a new set of fixtures for version v1 in the kvstore test suite, adding comprehensive test data for various RPC interactions, such as querying keys, fetching blocks by height or hash, and retrieving block results. These changes enhance the test coverage for the v1 version of the kvstore module.

@melekes melekes self-assigned this Jun 30, 2025
@melekes melekes requested a review from Copilot June 30, 2025 10:28
@melekes melekes mentioned this pull request Jun 30, 2025
7 tasks
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces v1 fixtures for the kvstore RPC tests and updates the dockerized probe to target CometBFT v1.0.0.

  • Updated tools/rpc-probe docs and Makefile to use CometBFT v1.0.0 and corrected RPC links.
  • Added comprehensive outgoing/incoming JSON fixtures under rpc/tests/kvstore_fixtures/v1.
  • Noted placeholder (empty) incoming subscribe_newblock.json.

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.

File Description
tools/rpc-probe/README.md Adjusted Docker image tag and RPC docs URL
tools/rpc-probe/Makefile.toml Updated DOCKER_IMAGE to cometbft/cometbft:v1.0.0
rpc/tests/kvstore_fixtures/v1/incoming/subscribe_newblock.json Empty placeholder fixture; likely needs actual payload
Comments suppressed due to low confidence (2)

tools/rpc-probe/README.md:37

  • The example image tag here (v0.37.x) conflicts with the Makefile default (v1.0.0). Consider updating this line to use cometbft/cometbft:v1.0.0 for consistency.
cargo make --env DOCKER_IMAGE="cometbft/cometbft:v0.37.x"

rpc/tests/kvstore_fixtures/v1/incoming/subscribe_newblock.json:1

  • This incoming fixture is empty ({}) but all numbered variants include full event data. If tests rely on subscribe_newblock responses, populate this file with at least the minimal expected JSON structure.
{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants