feat(rpc): add kvstore fixtures for v1#118
Open
melekes wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces v1 fixtures for the kvstore RPC tests and updates the dockerized probe to target CometBFT v1.0.0.
- Updated
tools/rpc-probedocs and Makefile to use CometBFT v1.0.0 and corrected RPC links. - Added comprehensive outgoing/incoming JSON fixtures under
rpc/tests/kvstore_fixtures/v1. - Noted placeholder (empty) incoming
subscribe_newblock.json.
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rpc-probe/README.md | Adjusted Docker image tag and RPC docs URL |
| tools/rpc-probe/Makefile.toml | Updated DOCKER_IMAGE to cometbft/cometbft:v1.0.0 |
| rpc/tests/kvstore_fixtures/v1/incoming/subscribe_newblock.json | Empty placeholder fixture; likely needs actual payload |
Comments suppressed due to low confidence (2)
tools/rpc-probe/README.md:37
- The example image tag here (
v0.37.x) conflicts with the Makefile default (v1.0.0). Consider updating this line to usecometbft/cometbft:v1.0.0for consistency.
cargo make --env DOCKER_IMAGE="cometbft/cometbft:v0.37.x"
rpc/tests/kvstore_fixtures/v1/incoming/subscribe_newblock.json:1
- This incoming fixture is empty (
{}) but all numbered variants include full event data. If tests rely onsubscribe_newblockresponses, populate this file with at least the minimal expected JSON structure.
{}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new set of fixtures for version
v1in the kvstore test suite, adding comprehensive test data for various RPC interactions, such as querying keys, fetching blocks by height or hash, and retrieving block results. These changes enhance the test coverage for thev1version of the kvstore module.