Skip to content

Add iteration stop criteria#42

Open
mvfki wants to merge 1 commit into
cole-trapnell-lab:masterfrom
mvfki:master
Open

Add iteration stop criteria#42
mvfki wants to merge 1 commit into
cole-trapnell-lab:masterfrom
mvfki:master

Conversation

@mvfki

@mvfki mvfki commented Aug 14, 2023

Copy link
Copy Markdown

The current wrapper ignores the return value of the optimizer and runs as many iterations as users specify. The iteration should stop when no more optimization can be made. SImilar criteria are also seen in other leiden/louvain wrapper packages such as leidenAlg, Seurat and the original leidenalg.

@mvfki

mvfki commented Aug 14, 2023

Copy link
Copy Markdown
Author

Sorry for not saying this in the first place. I appreciate it a lot for building such a comprehensive wrapper of the whole Leiden library, especially for allowing all possible objective functions and offering access to values like modularity and quality, which are really valuable.
Please correct me if I indeed misunderstood the algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant