Allow aggregating expression by multiple columns#42
Merged
Conversation
Collaborator
Author
|
Per discussion with Maddy, the specificity scoring is now optional. This is the slowest step, and if we are aggregating by e.g. cell type and perturbation, we don't want specificity metrics to be stratified by perturbation status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended
hooke:::aggregated_expr_data()so that the user can specify multiple columns to aggregate by (e.g. both cell type and perturbation). I tested the updated function on default parameters and confirmed that it still returns the same result --mean_expression,fraction_expressing, andspecificityis equal for all values and the first column of the result is stillcell_groupif there is only one column. However, if multiple columns are specified, the result now puts all of those columns first, for example:returns: