fix: mandate session-token regular expression injection #2548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onchainkit/packages/onchainkit/scripts/publish-prerelease.js
Line 117 in de893d7
fix this issue, we need to ensure that the value of
tag—which is passed from user input viaprocess.argv—is properly escaped for use in a regular expression. The recommended, reliable way to do this is to use a well-established sanitization helper, such as Lodash'sescapeRegExpfunction. As Lodash is a mainstream dependency, it's safe and reasonable to add it as an import to this script.The fix involves:
escapeRegExpto keep the import minimal).tagbefore incorporating it into the regex in line 117. Assign the result to a local variable (e.g.,escapedTag).escapedTagin the regex construction.These edits should be made within the
getNextVersionNumberfunction inpackages/onchainkit/scripts/publish-prerelease.js.