Open
Conversation
Replace URL-based editMode detection for inline editing loading with a loadInlineEditing flag in the seed config. The server sets the flag, the jbuilder template renders it and derives translation inclusion from it. This prepares for other features using the same pattern to control client-side loading. REDMINE-21261
Set loadCommenting in the seed config for preview mode so the frontend dynamically imports commenting components after hydration. Review translations are now derived from the same flag. This allows server-side gating of commenting via the seed options. REDMINE-21261
tf
force-pushed
the
commenting-preview-loading
branch
from
cd04666 to
31094ba
Compare
Register a commenting feature flag so commenting can be enabled per account or entry. The loadCommenting seed flag is only set when the feature is active, preventing commenting components from loading otherwise. REDMINE-21261
tf
force-pushed
the
commenting-preview-loading
branch
from
31094ba to
e1897ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261