🔊 Add background sounds to levels + mute button#100
Open
GARYPOU wants to merge 3 commits intocodergautam:masterfrom
Open
🔊 Add background sounds to levels + mute button#100GARYPOU wants to merge 3 commits intocodergautam:masterfrom
GARYPOU wants to merge 3 commits intocodergautam:masterfrom
Conversation
Owner
|
Could you let me know where you are getting these sounds and if they are properly licensed? Thank you! |
Author
|
Hi, quick update on the sounds from my previous message: those weren't properly licensed, so please don't include them in the PR. I'll replace them with royalty-free, license-free alternatives and follow up soon. Apologies for the oversight! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys, i did it.
This PR implements background audio for the game levels, along with a mute toggle button to give players control over the sound.
I test it in the 1 player and multy player mode and it work on both.
If you don t like something, tell me and i can change it :).