Migrate to use RenderState #75
Merged
+2,259
−1,494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
force-pushed
the
renderstate
branch
2 times, most recently
from
88a0bd6 to
edc25c5
Compare
From Mitchell's comment on HN: https://news.ycombinator.com/item?id=46111944This should improve performance dramatically.This also adds a basic set of benchmarks which have not yet been optimized.
kylecarbs
force-pushed
the
renderstate
branch
from
edc25c5 to
96da9d4
Compare
sreya
force-pushed
the
renderstate
branch
3 times, most recently
from
9fb7cd8 to
42cf82a
Compare
- Add GhosttyTerminalConfig struct and ghostty_terminal_new_with_config to WASM API - Update GhosttyTerminal constructor to accept optional config parameter - Update Ghostty.createTerminal() to pass config through - Use same parseColorToHex() and buildWasmConfig() pattern as main branch - Fix double semicolon formatting issue in terminal.ts - Add tests for config (scrollback, theme colors, palette colors) Restored config options: - scrollbackLimit: Max scrollback lines (0 = unlimited) - fgColor: Default foreground color (0xRRGGBB) - bgColor: Default background color (0xRRGGBB) - cursorColor: Cursor color (0xRRGGBB) - palette: 16-color ANSI palette
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Mitchell's comment on HN: https://news.ycombinator.com/item?id=46111944This should improve performance dramatically.This also adds a basic set of benchmarks which have not yet been optimized.