Repository navigation
fix: cast OCI8 batch subquery values so updateBatch() and deleteBatch() accept mixed PHP types - #10602
Open
paulbalandan wants to merge 2 commits into
Open
fix: cast OCI8 batch subquery values so updateBatch() and deleteBatch() accept mixed PHP types#10602paulbalandan wants to merge 2 commits into
updateBatch() and deleteBatch() accept mixed PHP types#10602paulbalandan wants to merge 2 commits into
Conversation
carson-codeigniter4
Bot
added
the
bug
paulbalandan
force-pushed
the
oci8-batch-mixed-types
branch
from
October 6, 2026 11:37
cd09931 to
58d5248
Compare
…eBatch()` accept mixed PHP types
paulbalandan
force-pushed
the
oci8-batch-mixed-types
branch
from
October 6, 2026 12:22
58d5248 to
7f6d37b
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Enum/array operations remain invalid on PostgreSQL, and schema-qualified tables bypass the new casts.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Assuming develop as the base, this PR adds type-aware batch subqueries for PostgreSQL and OCI8.
Changes:
- Casts batch values using destination-column metadata.
- Adds mixed-type update/delete regression tests.
- Documents the fix in the 4.7.5 changelog.
Validation: no project tests run; multi-driver validation remains for CI.
| File | Description |
|---|---|
system/Database/Postgre/Builder.php |
Adds typed PostgreSQL batch values. |
system/Database/OCI8/Builder.php |
Adds typed OCI8 batch values. |
tests/system/Database/Builder/UpdateTest.php |
Tests PostgreSQL enum/array SQL generation. |
tests/system/Database/Live/UpdateTest.php |
Tests mixed-type batch updates. |
tests/system/Database/Live/DeleteTest.php |
Tests mixed-type batch deletes. |
user_guide_src/source/changelogs/v4.7.5.rst |
Records the database fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulbalandan
force-pushed
the
oci8-batch-mixed-types
branch
from
October 6, 2026 12:56
7f6d37b to
d2f0be2
Compare
5 tasks done
…tch()` accept mixed PHP types
paulbalandan
force-pushed
the
oci8-batch-mixed-types
branch
from
October 6, 2026 13:11
d2f0be2 to
2005b18
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same bug as #10599 and stacked on #10601.
Checklist: