Skip to content

Conversation

sparsick
Copy link

@sparsick sparsick commented Oct 9, 2025

No description provided.

@slawekjaranowski
Copy link
Member

why not JUnit 5?

@sparsick
Copy link
Author

sparsick commented Oct 9, 2025

The rest of the code base is junit 4 and want to have a minimal change. But of course Junit 5 would be better. Let me take a look on it tomorrow. Thanks for your feedback.

@sparsick
Copy link
Author

@slawekjaranowski

Many tests are based on PlexusTestCase and that needs JUnit 3. Therefore, I only eliminate the direct dependency on JUnit 3 in this PR. I will put it on my to-do list.

Do you have a hint how to handle PlexusTestCase with JUnit 5?

@slawekjaranowski
Copy link
Member

@slawekjaranowski

Many tests are based on PlexusTestCase and that needs JUnit 3. Therefore, I only eliminate the direct dependency on JUnit 3 in this PR. I will put it on my to-do list.

Do you have a hint how to handle PlexusTestCase with JUnit 5?

We can try with plexus-testing - example:
https://github.com/codehaus-plexus/plexus-testing/blob/master/src/test/java/org/codehaus/plexus/testing/PlexusTestJavaxTest.java

@sparsick
Copy link
Author

@slawekjaranowski Thx for the link, I will take a look on it.

@slawekjaranowski
Copy link
Member

also new version released with simple documentation
https://codehaus-plexus.github.io/plexus-testing/

@sparsick sparsick marked this pull request as draft October 13, 2025 08:54
@sparsick
Copy link
Author

@slawekjaranowski

migrate one test based on your hint. Unfortunately, I have to use PlexusExtension directly, because of some container configuration customize. Do you think this is the way to go? Or did I oversee anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants