Skip to content

Updated the youtube embed so it also works with HTTPS #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
danieltome wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated the youtube embed so it also works with HTTPS #3

danieltome wants to merge 2 commits into from

Conversation

@danieltome
Copy link

@danieltome danieltome commented Aug 12, 2015

Hi,

Thanks for your great work on the youmax gallery. I've had an issue when using this on a HTTPS url.
It's a quick fix, I thought I'd send you a pull request.

cheers,
Dan

Daniel Tome added 2 commits August 13, 2015 09:50
Updated the youtube embed so it also works with HTTPS
8b96635
If a video is made private on a playlist. Then the thumbnail array is…
2f89a2c 
… missing from the snippet array.

This bit of code, just checkst that the thumbnail exists and adds it to the videoIdArray only if it exists.
@danieltome
Copy link
Author

danieltome commented Aug 13, 2015

  • One commit is for allowing this to work over HTTPS without throwing the security warning
  • The other is to check if the thumbnail is available (to replicate the error: try making a video private in a playlist)

@danieltome danieltome closed this Aug 13, 2015
@danieltome danieltome reopened this Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danieltome