feat: switched to OSS Argo CD and Argo Helm, removed Argo CD CF specific values from va… #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues.yaml Signed-off-by: reggie-k <[email protected]>
…lues.yaml Signed-off-by: reggie-k <[email protected]>
|
/e2e |
|
/e2e |
…-helm into feat/ditch-argocd-and-argo-helm-fork
Signed-off-by: reggie-k <[email protected]>
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lues.yaml
What
Moving to distributing Codefresh GitOps Runtime without the fork.
Removed custom action for
Rolloutsfrom the Argo CD cm as they are present in OSS.Removed
applicationVersioningsection since it is not present in the OSS Argo CD chart.Added
application.instanceLabelKey: ""cause it used to be on our fork of Argo Helm. We need to consider whether still needed as it differs from Argo CD default config.Added disable notifications cause it used to be on our fork of Argo Helm. We need to consider whether still needed as it differs from Argo CD default config.
Overridden Redis image cause Argo CD 3.1.9 comes with an OLDER version than we ship with our runtime, so if Redis is downgraded as a resulting from moving from 0.24/0.25 to M1, customers will experience downtime. That's why Redis is at a higher version.
This version comes without Monorepo Controller, as per the decision to include it when it is finished in OSS.
Implications
Implicitly removed
kustomize.setNamespace.enabled: falsewhich was on our fork of Argo Helm, it was used in Argo CD fork.Why
Notes