Skip to content

feat: external argocd unders .values.global.integrations #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: external argocd unders .values.global.integrations #808

wants to merge 9 commits into from

Conversation

@mikhail-klimko
Copy link
Contributor

@mikhail-klimko mikhail-klimko commented Oct 13, 2025 •
edited
Loading

What

  • Move .Values.global.external-argo-cd into .Values.global.integrations.argo-cd
  • Don't use templates from argo-cd subchart. Use .Values.argo-cd directly for helpers

Why

Notes

@mikhail-klimko
Copy link
Contributor Author

/e2e

@mikhail-klimko
Copy link
Contributor Author

/e2e

@mikhail-klimko mikhail-klimko marked this pull request as ready for review October 14, 2025 07:47
@mikhail-klimko mikhail-klimko requested review from a team as code owners October 14, 2025 07:47
@mikhail-klimko
Copy link
Contributor Author

/e2e

1 similar comment
@mikhail-klimko
Copy link
Contributor Author

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zarbis zarbis zarbis approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikhail-klimko @zarbis