Skip to content

Don't stop all collectors if one fails #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liamphmurphy wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Don't stop all collectors if one fails #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c719348
use Promise.allSettled, writeLocal now returns promises as well
liamphmurphy Sep 5, 2022
8454e5a
rename local compose file, add console.log tweak
liamphmurphy Sep 5, 2022
556a6e8
Update src/writeHelper.js
liamphmurphy Sep 6, 2022
4eec14e
change fs import
liamphmurphy Sep 11, 2022
210c5b6
merge changes
liamphmurphy Sep 11, 2022
1ffc8c3
final touchups
liamphmurphy Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 local-docker-compose.yml → local-docker-compose.yaml
View file
Open in desktop
File renamed without changes.
11 changes: 7 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,15 @@ function saveVehicles() {

return writeHelper.writeToS3(s3Bucket, agencyInfo.id, currentDateTime, vehicles);
})
.catch((err) => {
console.log(err);
});
});

Promise.all(promises);
// Do not reject all promises when one of them is rejected, but do output why one (or more) was rejected.
Promise.allSettled(promises)
.then((results) => results.forEach((result) => {
if(result.status == "rejected") {
console.log("received a rejected promise with reason:", result.reason)
}
}));
}

function storeLocal() {
Expand Down
17 changes: 9 additions & 8 deletions src/writeHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
const AWS = require('aws-sdk');
const fs = require('fs');
const s3 = new AWS.S3();
const { writeFile } = require('fs/promises');

var zlib = require('zlib');

const s3 = new AWS.S3();


function compressData(data) {
return new Promise((resolve, _) => {
Expand All @@ -17,12 +19,11 @@ function writeLocal(agency, currentDateTime, data) {
const version = "v1";
const fileName = `/tmp/${agency}_${version}_${currentTimestamp}.json`

fs.writeFile(fileName, JSON.stringify(data), err => {
if (err) {
console.error(err);
}
console.log("wrote", fileName)
});
return writeFile(fileName, JSON.stringify(data))
Copy link
Copy Markdown

@mindblight mindblight Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Does this work without importing writeFile?

import { writeFile } from 'fs/promises';`

Copy link
Copy Markdown

@mindblight mindblight Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. Just realized this project is using CommonJS.

const { writeFile } = require('fs/promises);

Copy link
Copy Markdown
Contributor Author

@liamphmurphy liamphmurphy Sep 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep the second way seems to work as expected, thanks for the suggestion 👍

.then((data) => {
console.log("wrote", fileName);
return data;
});
}

function writeToS3(s3Bucket, agency, currentDateTime, data) {
Expand Down