Skip to content

Conversation

@mounigopisetti1162
Copy link

This feature enables extraction of both table names and column names from SQL queries.

@mounigopisetti1162 mounigopisetti1162 marked this pull request as draft December 9, 2025 09:42
@mounigopisetti1162 mounigopisetti1162 marked this pull request as ready for review December 9, 2025 09:44
@mounigopisetti1162 mounigopisetti1162 marked this pull request as draft December 9, 2025 09:44
@mounigopisetti1162 mounigopisetti1162 marked this pull request as ready for review December 9, 2025 09:45
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs test cases
  • Need a formatter run on the file after these changes

@SanjulaGanepola SanjulaGanepola self-requested a review December 22, 2025 22:16
@SanjulaGanepola SanjulaGanepola mentioned this pull request Jan 16, 2026
11 tasks
@mounikagopisetti1314
Copy link

mounikagopisetti1314 commented Jan 20, 2026

Hi @worksofliam I have added the testcases for the function and its working as expected,
the blocks.test.ts file contains the test cases associated with the getColumnsAndTable function

@worksofliam worksofliam self-requested a review January 20, 2026 14:09
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All files need formatting
  2. What is the purpose of this? This seems very similar to getObjectReferences?

@worksofliam
Copy link
Member

Also, this needs a lot more tests. At least 10 because of the volatility of this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants