Skip to content

⚡️ Speed up function _get_default_engine_remote_uri by 53% #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _get_default_engine_remote_uri by 53% #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions xarray/backends/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,16 @@


def _get_default_engine_remote_uri() -> Literal["netcdf4", "pydap"]:
engine: Literal["netcdf4", "pydap"]
try:
import netCDF4 # noqa: F401

engine = "netcdf4"
return "netcdf4"
except ImportError: # pragma: no cover
try:
import pydap # noqa: F401

engine = "pydap"
return "pydap"
except ImportError:
raise ValueError(
"netCDF4 or pydap is required for accessing "
"remote datasets via OPeNDAP"
)
return engine


def _get_default_engine_gz() -> Literal["scipy"]:
Expand All @@ -116,7 +110,6 @@ def _get_default_engine_gz() -> Literal["scipy"]:
def _get_default_engine_netcdf() -> Literal["netcdf4", "scipy"]:
engine: Literal["netcdf4", "scipy"]
try:
import netCDF4 # noqa: F401

engine = "netcdf4"
except ImportError: # pragma: no cover
Expand Down