Skip to content

⚡️ Speed up method AsyncOperationPool._get_operation by 33% #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method AsyncOperationPool._get_operation by 33% #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions skyvern/forge/async_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ def add_operations(self, task_id: str, operations: list[AsyncOperation]) -> None
self._add_operation(task_id, operation)

def _get_operation(self, task_id: str, agent_phase: AgentPhase) -> AsyncOperation | None:
# Direct dictionary access and exception handling to minimize overhead
try:
return self._operations[task_id][agent_phase]
except KeyError:
# Avoid double exception overhead by nested .get lookups
phase_ops = self._operations.get(task_id)
if phase_ops is None:
return None
return phase_ops.get(agent_phase)

def _remove_operations(self, task_id: str) -> None:
if task_id in self._operations:
Expand Down