Skip to content

⚡️ Speed up function encode_query by 18% #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function encode_query by 18% #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions skyvern/client/core/query_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,28 @@ def traverse_query_dict(dict_flat: Dict[str, Any], key_prefix: Optional[str] = N


def single_query_encoder(query_key: str, query_value: Any) -> List[Tuple[str, Any]]:
if isinstance(query_value, pydantic.BaseModel) or isinstance(query_value, dict):
if isinstance(query_value, pydantic.BaseModel):
obj_dict = query_value.dict(by_alias=True)
else:
obj_dict = query_value
# Use local variables for fast lookup of often-used functions
isinstance_ = isinstance
BaseModel = pydantic.BaseModel

# Single isinstance() check instead of two, for pydantic.BaseModel | dict scenario
if isinstance_(query_value, BaseModel):
obj_dict = query_value.dict(by_alias=True)
return traverse_query_dict(obj_dict, query_key)
elif isinstance(query_value, list):
elif isinstance_(query_value, dict):
return traverse_query_dict(query_value, query_key)
elif isinstance_(query_value, list):
encoded_values: List[Tuple[str, Any]] = []
append = encoded_values.append
extend = encoded_values.extend
for value in query_value:
if isinstance(value, pydantic.BaseModel) or isinstance(value, dict):
if isinstance(value, pydantic.BaseModel):
obj_dict = value.dict(by_alias=True)
elif isinstance(value, dict):
obj_dict = value

encoded_values.extend(single_query_encoder(query_key, obj_dict))
if isinstance_(value, BaseModel):
obj_dict = value.dict(by_alias=True)
extend(traverse_query_dict(obj_dict, query_key))
elif isinstance_(value, dict):
extend(traverse_query_dict(value, query_key))
else:
encoded_values.append((query_key, value))
append((query_key, value))

return encoded_values

Expand All @@ -52,7 +56,8 @@ def encode_query(query: Optional[Dict[str, Any]]) -> Optional[List[Tuple[str, An
if query is None:
return None

encoded_query = []
encoded_query: List[Tuple[str, Any]] = []
extend = encoded_query.extend
for k, v in query.items():
encoded_query.extend(single_query_encoder(k, v))
extend(single_query_encoder(k, v))
return encoded_query