Skip to content

⚡️ Speed up method SkyvernLocator.locator by 10% #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SkyvernLocator.locator by 10% #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion skyvern/library/skyvern_locator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,12 @@ def filter(self, **kwargs: Any) -> "SkyvernLocator":

def locator(self, selector: str, **kwargs: Any) -> "SkyvernLocator":
"""Find a descendant element."""
return SkyvernLocator(self._locator.locator(selector, **kwargs))
# Micro-optimization: Avoid unnecessary allocation of kwargs dict if none passed
if not kwargs:
new_locator = self._locator.locator(selector)
else:
new_locator = self._locator.locator(selector, **kwargs)
return SkyvernLocator(new_locator)

def get_by_label(self, text: str | Pattern[str], **kwargs: Any) -> "SkyvernLocator":
"""Find an input element by its associated label text."""
Expand Down