Skip to content

⚡️ Speed up method OneNoteDataSource.groups_onenote_notebooks_section_groups_sections_update_pages_content by 7% #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method OneNoteDataSource.groups_onenote_notebooks_section_groups_sections_update_pages_content by 7% #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 26 additions & 22 deletions backend/python/app/sources/external/microsoft/one_note/one_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -2725,27 +2723,33 @@ async def groups_onenote_notebooks_section_groups_sections_update_pages_content(
"""
# Build query parameters including OData for OneNote
try:
# Use typed query parameters
query_params = RequestConfiguration()
# Set query parameters using typed object properties
if select:
query_params.select = select if isinstance(select, list) else [select]
if expand:
query_params.expand = expand if isinstance(expand, list) else [expand]
if filter:
query_params.filter = filter
if orderby:
query_params.orderby = orderby
if search:
query_params.search = search
if top is not None:
query_params.top = top
if skip is not None:
query_params.skip = skip

# Create proper typed request configuration
# Use a single RequestConfiguration object for both headers and query parameters.
config = RequestConfiguration()
config.query_parameters = query_params

# Only allocate and assign query_parameters when necessary
any_query_param = (
select or expand or filter is not None or orderby is not None or
search is not None or top is not None or skip is not None
)
if any_query_param:
query_params = RequestConfiguration()
# Set query parameters using typed object properties
if select:
query_params.select = select if isinstance(select, list) else [select]
if expand:
query_params.expand = expand if isinstance(expand, list) else [expand]
if filter is not None:
query_params.filter = filter
if orderby is not None:
query_params.orderby = orderby
if search is not None:
query_params.search = search
if top is not None:
query_params.top = top
if skip is not None:
query_params.skip = skip

config.query_parameters = query_params

if headers:
config.headers = headers
Expand Down