Skip to content

⚡️ Speed up method EarlyStopping.get_monitor_value by 14% #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method EarlyStopping.get_monitor_value by 14% #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions keras/src/callbacks/early_stopping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,17 @@ def on_train_end(self, logs=None):
self.model.set_weights(self.best_weights)

def get_monitor_value(self, logs):
logs = logs or {}
monitor_value = logs.get(self.monitor)
if monitor_value is None:
# Optimize logs.get access pattern: use local lookup and avoid list() conversion
# Avoid unnecessary computation by evaluating keys only if needed
if logs is None or self.monitor not in logs:
available = ", ".join(logs.keys()) if logs else ""
warnings.warn(
(
f"Early stopping conditioned on metric `{self.monitor}` "
"which is not available. "
f"Available metrics are: {','.join(list(logs.keys()))}"
f"Available metrics are: {available}"
),
stacklevel=2,
)
return monitor_value
return None
return logs[self.monitor]