Enhance testBg9Recycle function#294
Open
andy1li wants to merge 1 commit into
Open
Conversation
|
Triggered a Github Actions job to update fixtures. |
github-actions
Bot
removed
the
regenerate-fixtures
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0fa8dc3. Configure here.
…st and updating job number handling for recycled jobs
|
Triggered a Github Actions job to update fixtures. |
github-actions
Bot
removed
the
regenerate-fixtures
cursor Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
- Investigated hypothesis that bash version in CI is too low - Hypothesis is FALSE: Alpine uses bash 5.3.3 which is modern - Real issue: Test has incorrect expectations about job number recycling - Bash only recycles job numbers after jobs are fully removed from table - Tested and verified behavior across bash 5.2 and 5.3 - Provided recommendations for fixing the test Co-authored-by: Andy Li <andy1li@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Changes are limited to integration test expectations in
stage_bg9.go; no production shell behavior is modified.Overview
testBg9Recyclenow models job-number recycling with three background jobs still running when job 2 finishes, instead of only two.A
sleep 50background job is started as job 3 before the FIFO is closed so job 2 can be reaped. Expectations for the reapedcatjob usePreviousJob(-) rather thanCurrentJob, and the follow-up background launch usessleep 10assigned to recycled job 2, with an updated success message.The final
jobsassertion expects three running entries (jobs 1, 2, 3) with markers unmarked, current (+), and previous (-) respectively.Reviewed by Cursor Bugbot for commit b1fddf4. Bugbot is set up for automated code reviews on this repo. Configure here.