Parameter Expansion (2/2)

[UdeshyaDhungana]

Note

Low Risk
Changes are confined to test stages and golden fixtures; primary risk is increased flakiness if randomized names/values ever collide or produce edge-case tokens.

Overview
Adds concrete implementations for testPEX5, testPEX6, and testPEX7, replacing stubs with end-to-end tests that set variables via declare and then verify argument expansion when invoking a generated signature_printer executable.

Stage 5 asserts basic $VAR expansion into argv, stage 6 asserts brace form ${VAR} including embedding within surrounding literals, and stage 7 asserts missing variables expand to an empty string (including inside a larger token). Updates the bash fixture parameter_expansion/pass to include the new expected transcripts (PATH setup, executable listing, and multiline argv output).

^{Reviewed by Cursor Bugbot for commit 79a29ac. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: No-op strings.Join wrapping a single string variable
  • Replaced the no-op strings.Join([]string{command}, " ") with just command in all three files, and removed the unused strings import from stage_pex7.go.

Or push these changes by commenting:

@cursor push 8e86eea1c7

Preview (8e86eea1c7)

diff --git a/internal/stage_pex5.go b/internal/stage_pex5.go
--- a/internal/stage_pex5.go
+++ b/internal/stage_pex5.go
@@ -67,7 +67,7 @@
 	}
 
 	testCase := test_cases.CommandWithMultilineResponseTestCase{
-		Command:            strings.Join([]string{command}, " "),
+		Command:            command,
 		MultiLineAssertion: assertions.NewMultiLineAssertion(expectedLines),
 		SuccessMessage:     "✓ Received expected response",
 	}

diff --git a/internal/stage_pex6.go b/internal/stage_pex6.go
--- a/internal/stage_pex6.go
+++ b/internal/stage_pex6.go
@@ -76,7 +76,7 @@
 	}
 
 	testCase := test_cases.CommandWithMultilineResponseTestCase{
-		Command:            strings.Join([]string{command}, " "),
+		Command:            command,
 		MultiLineAssertion: assertions.NewMultiLineAssertion(expectedLines),
 		SuccessMessage:     "✓ Received expected response",
 	}

diff --git a/internal/stage_pex7.go b/internal/stage_pex7.go
--- a/internal/stage_pex7.go
+++ b/internal/stage_pex7.go
@@ -3,7 +3,6 @@
 import (
 	"fmt"
 	"strconv"
-	"strings"
 
 	"github.com/codecrafters-io/shell-tester/internal/assertions"
 	"github.com/codecrafters-io/shell-tester/internal/logged_shell_asserter"
@@ -55,7 +54,7 @@
 	}
 
 	testCase := test_cases.CommandWithMultilineResponseTestCase{
-		Command:            strings.Join([]string{command}, " "),
+		Command:            command,
 		MultiLineAssertion: assertions.NewMultiLineAssertion(expectedLines),
 		SuccessMessage:     "✓ Received expected response",
 	}

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit f556693. Configure here.}