Skip to content

Conversation

@UdeshyaDhungana
Copy link
Contributor

@UdeshyaDhungana UdeshyaDhungana commented Nov 21, 2025

  • Did not include failure fixtures since we're re-using OrderedLinesAssertion

Note

Adds multiple-match (-o) test coverage and fixtures, updates stage inputs, and improves the grep wrapper to translate -E to -P robustly.

  • Tests:
    • Update internal/grep/grep_test.go to support -o via onlyMatches flag and build grep args accordingly.
    • Add stdin tests for -o with single, multiple single-line, and multi-line matches.
    • Add multiple_matches_pass case in internal/stages_test.go for stages cj0, ss2, bo4.
    • Tweak internal/stage_multiple_matches_multiple_lines.go to include inputs with multiple phrase matches.
  • Fixtures:
    • Add internal/test_helpers/fixtures/multiple_matches/success expected output.
  • Scripts:
    • Replace sh with bash and translate -E to -P in-place in internal/test_helpers/pass_all/your_grep.sh; pass rebuilt args to ggrep/find_grep_linux.sh.

Written by Cursor Bugbot for commit bc593c8. This will update automatically on new commits. Configure here.

@UdeshyaDhungana UdeshyaDhungana changed the title Add fixture for multiple matches Fixtures for multiple matches Nov 21, 2025
@UdeshyaDhungana UdeshyaDhungana changed the title Fixtures for multiple matches Fixtures for Multiple Matches Nov 21, 2025
@UdeshyaDhungana UdeshyaDhungana changed the title Fixtures for Multiple Matches Fixture for Multiple Matches Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants