Skip to content

Conversation

@StanBarrows
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 10, 2025 09:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the order of visibility and readonly modifiers in constructor promoted properties across all Request classes. The change moves from readonly <visibility> to <visibility> readonly for consistency with PHP coding standards.

  • Changed visibility modifier order from readonly public/protected to public/protected readonly
  • Applied consistently across all Request classes in various domain folders
  • No functional changes, only code style standardization

Reviewed Changes

Copilot reviewed 115 out of 115 changed files in this pull request and generated no comments.

Show a summary per file
File Description
All VatPeriods Request files Updated constructor parameter modifiers to follow public readonly pattern
All Users Request files Updated constructor parameter modifiers to follow public readonly pattern
All Units Request files Updated constructor parameter modifiers to follow public readonly pattern
All Titles Request files Updated constructor parameter modifiers, including protected parameters
All Taxes Request files Updated constructor parameter modifiers to follow public readonly pattern
All Salutations Request files Updated constructor parameter modifiers, including protected parameters
All Reports Request files Updated constructor parameter modifiers to follow public readonly pattern
All QrPayments Request files Updated constructor parameter modifiers to follow public readonly pattern
All Projects Request files Updated constructor parameter modifiers to follow public readonly pattern
All Payments Request files Updated constructor parameter modifiers to follow public readonly pattern
All PaymentTypes Request files Updated constructor parameter modifiers to follow public readonly pattern
All Notes Request files Updated constructor parameter modifiers, including protected parameters
All ManualEntries Request files Updated constructor parameter modifiers, including protected parameters
All Languages Request files Updated constructor parameter modifiers to follow public readonly pattern
All Invoices Request files Updated constructor parameter modifiers to follow public readonly pattern
All IbanPayments Request files Updated constructor parameter modifiers to follow public readonly pattern
All Files Request files Updated constructor parameter modifiers, including protected parameters
All DocumentSettings Request files Updated constructor parameter modifiers to follow public readonly pattern
All Currencies Request files Updated constructor parameter modifiers, including protected parameters
All Contacts Request files Updated constructor parameter modifiers, including protected parameters
All ContactSectors Request files Updated constructor parameter modifiers to follow public readonly pattern
All ContactRelations Request files Updated constructor parameter modifiers, including protected parameters
All ContactGroups Request files Updated constructor parameter modifiers, including protected parameters
All ContactAdditionalAddresses Request files Updated constructor parameter modifiers, including protected parameters
All CompanyProfiles Request files Updated constructor parameter modifiers to follow public readonly pattern
All CalendarYears Request files Updated constructor parameter modifiers, including protected parameters
All BusinessYears Request files Updated constructor parameter modifiers to follow public readonly pattern
All BusinessActivities Request files Updated constructor parameter modifiers to follow public readonly pattern
All BankAccounts Request files Updated constructor parameter modifiers to follow public readonly pattern
All AdditionalAddresses Request files Updated constructor parameter modifiers, including protected parameters
All Accounts Request files Updated constructor parameter modifiers to follow public readonly pattern
All AccountGroups Request files Updated constructor parameter modifiers to follow public readonly pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StanBarrows StanBarrows merged commit a4dbc2f into main Nov 10, 2025
33 checks passed
@StanBarrows StanBarrows deleted the feature-pint branch November 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants