feat: add setup webview CF-2150 #176
Conversation
nedaKaighobadi
changed the title
Codacy's Analysis Summary3 new issues (≤ 1 medium issue) Review Pull Request in Codacy →
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new setup webview to the Codacy extension that displays when users are not authenticated. The webview shows an upgrade prompt that is conditionally hidden when the user is logged in.
Changes:
- Added a new setup webview with TypeScript provider and JavaScript client-side script
- Added CSS styles for the webview UI
- Upgraded VS Code engine version from 1.99.0 to 1.102.0
- Added @eslint/js v9.39.2 as a dependency
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/SetupView.ts | Implements the webview provider with login state management |
| src/views/scripts/setupScript.js | Client-side script for handling login state changes |
| src/views/styles/vscode.css | VS Code theme-aware styling for the webview |
| src/views/styles/reset.css | CSS reset for the webview |
| src/views/styles/main.css | Custom styles for setup list and upgrade box |
| src/extension.ts | Activates the setup webview on extension load |
| package.json | Updates VS Code version and adds new dependency |
| package-lock.json | Lock file updates for dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 24 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tyle for secondary button + add dependencies message
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ "$#" -eq 1 ] && [ "$1" = "download" ]; then | ||
| echo "Codacy cli v2 download succeeded" | ||
| else | ||
| eval "$run_command $*" |
There was a problem hiding this comment.
Using eval with user-provided arguments ($*) is a security risk as it can lead to command injection. Consider using direct command execution instead, such as "$run_command" "$@" which properly handles arguments without eval.
| eval "$run_command $*" | |
| "$run_command" "$@" |
| element.innerHTML = loadingHtml | ||
| return | ||
| } | ||
| linkNode.textContent = params.user ?? '' |
There was a problem hiding this comment.
is it a possibility for textContent to be empty? :O
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Various states:
Different themes:
