Skip to content

modify toggle children node remove logic #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

modify toggle children node remove logic #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1a3d2
adapt toggle node remove logic
drelaptop Jul 11, 2018
840a205
fix typo
drelaptop Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions creator_project/packages/creator-luacpp-support/core/parser/Toggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ class Toggle extends Node {
}

// remove Background and CheckMark
// on creator 1.9.x, checkmark and background is brother node, so we need remove both
Utils.remove_child_by_id(this, checkmark_component.node.__id__);
// on older version, checkmark is the child node of background, so only remove parent is ok
Utils.remove_child_by_id(this, background_node_id);

// 2nd: parse children
Expand Down