V3.8.9 backport from 4.0.0 alpha.8 - #19205
Merged
Merged
Conversation
…fter calling initDefault on a texture, resulting in the inability to retrieve texture.image. (#59)
* Fix memory leaks in Spine resource parsing on the web-side. * update external version # Conflicts: # native/external-config.json
…with the implementations of Vec2 and Vec4. (#57) * Fix the issue that the implementation of Vec3 equals is inconsistent with the implementations of Vec2 and Vec4. * Change approxEquals method to return boolean * Fix formatting of approxEquals method --------- Co-authored-by: hyde zhou <zlzhou.sh@outlook.com>
* Remove unneed function * Reorder import statement for approx in model.ts --------- Co-authored-by: hyde zhou <zlzhou.sh@outlook.com>
… be released last. (#75) * Fix out of memory for spine4.2 * update external version
…lution in 2.4.16 * 参考2.4.16，解决cocos在字节小游戏上下载文件，每隔2秒掉帧到30-40帧的问题。原因是_write方法里使用writeFileSync方法在字节小游戏上可能时长700ms，卡主游戏。修改方法是改成2.x的版本使用异步方法writeFile，cache-manager基本改成和2.4.16一样了 * 解决cocos在字节小游戏上下载文件，每隔2秒掉帧到30-40帧的问题。
…irst and then true within the same frame. (#84)
…mismatch (#89) * 1.基于 Box2D JSB 的2D物理系统 结束碰撞但不回调 2.回调个数BeginContact和EndContact不一致。 * recover logic of physics-2d/box2d-jsb/platform/physics-contact-listener.ts * add physics-2d/box2d-jsb/physics-contact-manager.ts
* the logic is consistent with box2d-jsb & box2d * Add return type to register/unregisterContactFixture, fix lint
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Author
|
@cocos-robot run test cases |
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -19896,9 +19896,9 @@
export class frustum extends Frustum {
constructor();
}
}
- export const VERSION = "3.8.8";
+ export const VERSION = "3.8.9";
/**
* @en
* The main namespace of Cocos engine, all engine core classes, functions, properties and constants are defined in this namespace.
* @zh
@@ -25064,9 +25064,9 @@
* @param x X axis position
* @param y Y axis position
* @param z Z axis position
*/
- setWorldPosition(x: number, y: number, z: number): void;
+ setWorldPosition(x: number, y: number, z?: number): void;
/**
* @en Get position in world coordinate system, please try to pass `out` vector and reuse it to avoid garbage.
* @zh 获取世界坐标，注意，尽可能传递复用的 [[Vec3]] 以避免产生垃圾。
* @param out Set the result to out vector
|
|
@star-e, Please check the result of
Task Details |
|
@star-e, Please check the result of
Task Details |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
star-e
pushed a commit
that referenced
this pull request
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: