metrics: add compression counters #5412
Open
+679
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also rework the implementation so it's less confusing.
Add running counters that keep track of how many bytes were compressed and decompressed. The counters are segregated along the same lines where compression settings can differ: L5 vs L6 vs other levels, and data vs value vs other blocks. The intention is to estimate the CPU usage change for a different compression profile (in conjunction with data about each algorithm's performance, as obtained by the compression analyzer).
|
This change is |
annrpom
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
@annrpom reviewed 15 of 15 files at r1, 32 of 32 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base: move cache.Level to base
We also rework the implementation so it's less confusing.
metrics: add compression counters
Add running counters that keep track of how many bytes were compressed
and decompressed. The counters are segregated along the same lines
where compression settings can differ: L5 vs L6 vs other levels, and
data vs value vs other blocks.
The intention is to estimate the CPU usage change for a different
compression profile (in conjunction with data about each algorithm's
performance, as obtained by the compression analyzer).