logo.html: Make header icon responsive#592
Open
Anmolbansal1 wants to merge 1 commit intocoala:masterfrom
Open
Conversation
Contributor
Author
|
@shashank-b please review |
Dhiraj240
suggested changes
Jan 24, 2019
Member
There was a problem hiding this comment.
Please follow commit guidelines and then amend your commit message.
cc98e79 to
e6b6466
Compare
Contributor
Author
|
@Dhiraj240 please check now |
e6b6466 to
35c9aa2
Compare
jayvdb
reviewed
Jan 30, 2019
_static/logo.html
Outdated
| <div class="coala-logo-doc-low"> | ||
| <img width="187.5px" height="187.5px" src="_static/images/coala_logo.svg"> | ||
| </div> | ||
| </body> No newline at end of file |
35c9aa2 to
e2e3293
Compare
e2e3293 to
c594df2
Compare
logo.html: Display header according to screen width Now bear-header is rendered according to screen-width. Closes coala/landing-frontend#299
c594df2 to
e5597d8
Compare
Contributor
Author
|
@jayvdb please check now |
Member
|
@sangamcse can you take a look at this. We should be probably doing this in the artwork repo, and sync'ing here, etc? |
Member
sangamcse
suggested changes
Feb 4, 2019
| .. image:: _static/images/coala-header.png | ||
| :scale: 50 | ||
| :align: center | ||
| .. raw:: html |
Member
There was a problem hiding this comment.
Check if we can add SVG here or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the header icon of docs.coala.io more responsive.
Closes coala/landing-frontend#299
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
them.
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!