plugins/explain.py: Added explanation for "do not ask to ask". by yashasingh · Pull Request #404 · coala/corobo

yashasingh · 2017-11-27T18:39:16Z

This patch adds response in case a user asks abrupt question.

Closes #389

gitmate-bot · 2017-11-27T18:39:44Z

plugins/explain.py

+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '


E501 line too long (82 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:39:45Z

plugins/explain.py

+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '


E501 line too long (81 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:39:46Z

plugins/explain.py

+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '
+                             'description may pique their interest and get them to '


E501 line too long (84 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:39:46Z

plugins/explain.py

+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '


Line is longer than allowed. (82 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2017-11-27T18:39:47Z

plugins/explain.py

+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '


Line is longer than allowed. (81 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2017-11-27T18:39:48Z

plugins/explain.py

+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '
+                             'description may pique their interest and get them to '


Line is longer than allowed. (84 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2017-11-27T18:50:09Z

plugins/explain.py

+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '


E501 line too long (82 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:50:10Z

plugins/explain.py

+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '


E501 line too long (81 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:50:11Z

plugins/explain.py

+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '
+                             'description may pique their interest and get them to '


E501 line too long (84 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot · 2017-11-27T18:50:12Z

plugins/explain.py

+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '


Line is longer than allowed. (82 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2017-11-27T18:50:13Z

plugins/explain.py

+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '


Line is longer than allowed. (81 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2017-11-27T18:50:13Z

plugins/explain.py

+                             'on the channel and only every now and then glances '
+                             'what\'s going on is unlikely to answer to your '
+                             '"asking to ask" question, but your actual problem '
+                             'description may pique their interest and get them to '


Line is longer than allowed. (84 > 80)

Origin: LineLengthBear, Section: all.linelength.

yashasingh · 2017-11-27T18:57:54Z

I have made the required changes.

andrewda

Just a couple minor wording changes. Also, please be sure to squash your commits into one 😄

andrewda · 2017-11-28T00:54:19Z

plugins/explain.py

+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then '
+                             'glances what\'s going on is unlikely to answer '


"glances at what's going on [...]"

andrewda · 2017-11-28T00:56:37Z

plugins/explain.py

+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '
+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only every now and then '


"and only occasionally glances [...]" sounds a bit more natural here. Otherwise the "and"s begin to sound a little weird.

Okay. I shall do this.

prnvdixit

@yashasingh There are changes in the commit that are not associated with this issue - Please remove them. 👍

prnvdixit · 2017-11-28T12:28:25Z

plugins/explain.py

                     'newcomer Pull Request\n- merge a difficulty/low Pull '
                     'Request\n- review at least a difficulty/low or higher '
                     'Pull Request'
+        'do not ask to ask': 'This is a lazy way of asking your question '


Please, rephrase this line to be less "You did something quite wrong" to more "It's Ok, you just need to be careful from now on and ask specific questions". Current language might scare newcomers away 😄.

prnvdixit · 2017-11-28T12:32:32Z

plugins/explain.py

+        'do not ask to ask': 'This is a lazy way of asking your question '
+                             'because  you\'re asking for more than what '
+                             'you think you\'re asking. The solution is not '
+                             'to ask to ask, but just to ask by actaully '


You haven't explained what don't "ask to ask" actually means in a proper way (like describe the specific problem, tell us what you did to solve and didn't worked out, what others might have to do to regenerate the problem) 😉

Makman2 · 2017-11-30T14:35:18Z

Why is gitmate not complaining about the commit... it violates our style rules... CC @sils

Makman2 · 2017-11-30T14:36:00Z

However, this is my local coala run on this PR ;)

Project wide:
|    | [NORMAL] GitCommitBear:
|    | Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Added'

Project wide:
|    | [NORMAL] GitCommitBear:
|    | Shortlog of the HEAD commit contains 59 character(s). This is 9 character(s) longer than the limit (59 > 50).

Makman2 · 2017-11-30T14:36:22Z

unack dbe798a

yashasingh · 2017-11-30T15:25:34Z

@Makman2 Should I change my commit message ? Is there something else also to be done ?

prnvdixit · 2017-11-30T15:28:08Z

@yashasingh Just go through https://coala.io/commit - You would be fine 😄

This patch adds response in case a user asks abrupt question. Closes coala#389

Mixih · 2017-12-01T19:30:32Z

plugins/explain.py

+                             'you\'re asking for more than what you think '
+                             'you\'re asking. The solution is not to simply '
+                             'question people about them, but just to '
+                             'ask for your piece of information by actaully '


typo in "actually"

Mixih · 2017-12-01T19:31:57Z

plugins/explain.py

-                     'Pull Request'
+                     'Pull Request',
+        'do not ask to ask': 'This seems a lazy way of asking your question '
+                             'Don\'t take it personally. It\'s just that '


use double quotes around the whole string instead of escaping the single quotes. That way you can keep the single quotes in the string more readable. (this comment applies to all of the instances)

Mixih · 2017-12-01T19:32:52Z

plugins/explain.py

+        'do not ask to ask': 'This seems a lazy way of asking your question '
+                             'Don\'t take it personally. It\'s just that '
+                             'you\'re asking for more than what you think '
+                             'you\'re asking. The solution is not to simply '


the sentance The solution is not to simply [snip]... is too wordy. Please reword it to be more concise.

Mixih · 2017-12-01T19:33:08Z

plugins/explain.py

+                             'formalizing it in words. Someone who is idling '
+                             'on the channel and only occasionally glances '
+                             'at what\'s going on is unlikely to answer '
+                             'to your "asking to ask" question, but your '


delete to

jayvdb · 2017-12-02T00:46:12Z

unack 47c1fd0

prnvdixit · 2017-12-02T02:05:31Z

Also, commit Shortlog should be imperative - "Explain...."

gitmate-bot added process/pending review size/XS difficulty/newcomer labels Nov 27, 2017

gitmate-bot assigned yashasingh Nov 27, 2017

gitmate-bot reviewed Nov 27, 2017

View reviewed changes

andrewda suggested changes Nov 28, 2017

View reviewed changes

yashasingh force-pushed the patch#389 branch 2 times, most recently from f06efba to a0b1946 Compare November 28, 2017 11:02

gitmate-bot added size/S size/XS and removed size/XS size/S labels Nov 28, 2017

yashasingh force-pushed the patch#389 branch from 796098a to 67d21eb Compare November 28, 2017 12:33

prnvdixit suggested changes Nov 28, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Nov 28, 2017

yashasingh force-pushed the patch#389 branch from 67d21eb to bad2df7 Compare November 29, 2017 13:48

gitmate-bot added the process/pending review label Nov 29, 2017

Makman2 mentioned this pull request Nov 30, 2017

coafile/commit section: Enhance rules (like on other coala repos) #422

Closed

plugins/explain.py: Explains "Do not ask to ask"

47c1fd0

This patch adds response in case a user asks abrupt question. Closes coala#389

yashasingh force-pushed the patch#389 branch from dbe798a to 47c1fd0 Compare November 30, 2017 15:48

Mixih added size/S and removed area/labhub difficulty/medium difficulty/newcomer importance/low size/XS type/regex labels Dec 1, 2017

Mixih reviewed Dec 1, 2017

View reviewed changes

Mixih added process/wip and removed process/pending review labels Dec 1, 2017

gitmate-bot added the status/STALE label Dec 10, 2017

Makman2 added difficulty/newcomer and removed area/config bug difficulty/low importance/medium initiatives/gci labels Dec 11, 2017

gitmate-bot added the area/documentation label Dec 11, 2017

jayvdb unassigned andrewda and invisible-defects Apr 18, 2018

Comments

Conversation

yashasingh commented Nov 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashasingh commented Nov 27, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewda Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prnvdixit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Makman2 commented Nov 30, 2017

Uh oh!

Makman2 commented Nov 30, 2017

Uh oh!

Makman2 commented Nov 30, 2017

Uh oh!

yashasingh commented Nov 30, 2017

Uh oh!

prnvdixit commented Nov 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb commented Dec 2, 2017

Uh oh!

prnvdixit commented Dec 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

9 participants

andrewda Nov 28, 2017 •

edited

Loading

prnvdixit left a comment •

edited

Loading