feat: add basic error messages if the analyzed page send back a 401 or 403 HTTP status code#322
Draft
bgatellier wants to merge 2 commits intomasterfrom
Draft
feat: add basic error messages if the analyzed page send back a 401 or 403 HTTP status code#322bgatellier wants to merge 2 commits intomasterfrom
bgatellier wants to merge 2 commits intomasterfrom
Conversation
bgatellier
changed the title
vvatelot
reviewed
Feb 8, 2024
Comment on lines
+12
to
+21
| 401: `{{- i18n "Error401" | markdownify -}}`, | ||
| 403: `{{- i18n "Error403" | markdownify -}}`, | ||
| 404: `{{- i18n "Error404" | markdownify -}}`, | ||
| 422: `{{- i18n "Error422" | markdownify -}}`, | ||
| 429: `{{- i18n "Error429" | markdownify -}}`, | ||
| 500: `{{- i18n "Error500" | markdownify -}}`, | ||
| 502: `{{- i18n "Error502" | markdownify -}}`, | ||
| 504: `{{- i18n "Error504" | markdownify -}}`, | ||
| 520: `{{- i18n "Error520" | markdownify -}}`, | ||
| 521: `{{- i18n "Error521" | markdownify -}}`, |
Member
There was a problem hiding this comment.
Here, the API will not respond with a 401 or 403 status...
The tricky thing is that it will respond with a 521 code and this 521 code refers to the error code of the analyzed page 🤔
So the thing that would be perfect if to read the "referent" status code when a 521 occurs...
bgatellier
force-pushed
the
feat/401-403-errors
branch
2 times, most recently
from
800bd00 to
8336b61
Compare
bgatellier
force-pushed
the
feat/401-403-errors
branch
from
8336b61 to
7cef654
Compare
|
Cette pull request a été marquée comme inactive car elle n'a pas eu de mise à jour depuis 30 jours. Si elle n'est pas mise à jour d'ici 7 jours, elle sera fermée automatiquement. Pour éviter qu'elle soit fermée, vous pouvez ajouter le label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #301