Load images from docker daemon in export and relocate#834
Conversation
This is implemented by bumping pivotal/image-relocation to pick up the docker daemon support. Fixes cnabio#828
|
I'm wondering if this change is robust given this observation: #691 (comment). I need to investigate. |
|
I need to investigate that PR again, but from what I recall, we can't rely on the digest calculated locally (as different registries can output different digests for the same content).
Based on a recent discussion in #cnab and to the spec, we proposed adding digest to the images on the first push, if any digest is missing. What do you think? |
|
Supplying any missing digest on first push is a partial solution, but it doesn't cover the case where the bundle is never pushed. With this PR the following scenario becomes possible:
In this case, the image's content digest ends up being that which was derived from the daemon and may (I'm still investigating this) therefore be subject to the risk pointed out in the other PR. Without this PR, |
|
It turns out we can't depend on the docker daemon forming the same digest as a repository. It seems to do at the moment, but that's just (bad IMO) luck. Closing. |
This is implemented by bumping pivotal/image-relocation to pick up the docker
daemon support.
Fixes #828