Build Fixes from PR #765#775
Conversation
PR cnabio#765 forgot to commit changes to vendor to sync it to the changes to Gopkg.lock. This syncs the vendor directory with those changes.
carolynvs
requested review from
bacongobbler,
glyn,
jeremyrickard,
radu-matei,
silvin-lubecki,
technosophos and
vdice
as code owners
|
Tests are failing: |
That's why #774 bumps Go to 1.12. |
|
Sorry I'm aware, just in a meeting. Will fix in an hour. |
glyn
left a comment
glyn
left a comment
There was a problem hiding this comment.
Needs to bump Go to 1.12 like #774 did.
Note that I'd like this to be done in a way that any duffle maintainer could also do, so PR 774 avoids using quay.io/deis/lightweight-docker-go and uses standard golang images instead.
Please take a look at PR 774 as it may provide most if not all of what's needed to sync the vendor directory and fix the build.
|
@glyn I was hoping to just fix the build and let the go bumping happen in your PR (which looks great). I am 100% on board with switching to a better base image. I just wanted to focus on the changes that should have been in that PR to begin with, and not smoosh too many things together into this PR. |
technosophos
left a comment
technosophos
left a comment
There was a problem hiding this comment.
I see a linting fix, a Go 1.11 fix, and some updated dependencies, and this looks good to me.
|
I updated the title of the PR to better reflect what all ended up in this grab bag PR. 😀 |
|
@glyn Since this one does not require 1.12, can you re-review this one and see if we can get it in to quickly get things green again? |
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
LGTM.
I'm very much in favour of merging this PR first, then decide how to best switch to Go 1.12.
|
Okay. Since we've got a broken master right now, let's get this one merged, then start working on the 1.12 as a follow-up. |
7 participants
PR #765 didn't get a clean build before merging. This fixes the build on master by