Use Go 1.12 for docker builds

Dockerfile

@@ -1,4 +1,4 @@
-FROM quay.io/deis/lightweight-docker-go:v0.7.0
+FROM golang:1.12-alpine
 ARG LDFLAGS
 ENV CGO_ENABLED=0
 WORKDIR /go/src/github.com/deislabs/duffle

Makefile

@@ -22,7 +22,7 @@ BASE_PACKAGE_NAME := github.com/deislabs/duffle
 
 ifneq ($(SKIP_DOCKER),true)
 	PROJECT_ROOT := $(dir $(realpath $(firstword $(MAKEFILE_LIST))))
-	DEV_IMAGE := quay.io/deis/lightweight-docker-go:v0.7.0
+	DEV_IMAGE := golang:1.12-stretch
 	DOCKER_CMD := docker run \
 		-it \
 		--rm \
@@ -65,6 +65,14 @@ MUTABLE_IMAGE_NAME := $(DOCKER_REGISTRY)$(DOCKER_ORG)$(BASE_IMAGE_NAME):$(MUTABL
 dep:
 	$(DOCKER_CMD) dep ensure -v
 
+.PHONY: install-dep
+install-dep:
+	curl https://raw.githubusercontent.com/golang/dep/master/install.sh | INSTALL_DIRECTORY=/usr/local/bin sh
+
+.PHONY: install-golangci-lint
+install-golangci-lint:
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b /usr/local/bin v1.16.0
+
 .PHONY: goimports
 goimports:
 	$(DOCKER_CMD) sh -c "find . -name \"*.go\" | fgrep -v vendor/ | xargs goimports -w -local github.com/deislabs/duffle"

brigade.js

@@ -3,7 +3,7 @@ const { events, Job, Group } = require("brigadier");
 const projectOrg = "deislabs";
 const projectName = "duffle";
 
-const goImg = "quay.io/deis/lightweight-docker-go:v0.7.0";
+const goImg = "golang:1.12-stretch";
 const gopath = "/go"
 const localPath = gopath + `/src/github.com/${projectOrg}/${projectName}`;
 
@@ -67,7 +67,7 @@ function test() {
   // Run Go unit tests
   job.tasks = [
     `cd ${localPath}`,
-    "make verify-vendored-code lint test"
+    "make install-dep verify-vendored-code install-golangci-lint lint test"
   ];
   return job;
 }

pkg/driver/kubernetes.go

@@ -173,7 +173,7 @@ func (k *KubernetesDriver) Run(op *driver.Operation) error {
 		}
 
 		container.EnvFrom = []v1.EnvFromSource{
-			v1.EnvFromSource{
+			{
 				SecretRef: &v1.SecretEnvSource{
 					LocalObjectReference: v1.LocalObjectReference{
 						Name: envsecret.ObjectMeta.Name,
@@ -264,6 +264,9 @@ func (k *KubernetesDriver) watchJobStatusAndLogs(selector metav1.ListOptions, ou
 			break
 		}
 	}
+	if err != nil {
+		return err
+	}
 
 	// Wait for pod logs to finish printing
 	for i := 0; i < int(k.requiredCompletions); i++ {