This repository was archived by the owner on May 3, 2022. It is now read-only.
Add inital code coverage and publish test results#713
Open
radu-matei wants to merge 1 commit into
Open
Conversation
ghost
assigned
Kick off CI again Update display name Temporarily remove container Fix coverage Try gocover-cobertura Add coverage make target Fix makefile indentation Add gocov-xml to make bootstrap Remove gocov-html as Azure Pipelines auto-generates HTML report
radu-matei
force-pushed
the
azure-pipelines-coverage
branch
from
e87dc5a to
d5c8606
Compare
radu-matei
commented
Apr 17, 2019
| HAS_GOLANGCI := $(shell $(CHECK) golangci-lint) | ||
| HAS_GOIMPORTS := $(shell $(CHECK) goimports) | ||
| GOLANGCI_VERSION := v1.16.0 | ||
| HAS_COCOV_XML := $(shell command -v gocov-xml;) |
Contributor
There was a problem hiding this comment.
lmk when it's fixed and u want a review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This publishes the test results and code coverage to Azure Pipelines.
I'm still mildly annoyed that the current Azure Pipelines task ignores a custom code coverage report that we could upload (and not include bogus "classes", or "assemblies"), but it feels like a good start.
Thoughts?