This is for PyPI integration for cert-uefi-parser. #1
+358
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace boolean parameter (always True) with an ArgumentParser to standardize error formatting. Move the GUI check to before the file is parser to avoid wasted effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the build, packaging, and documentation for the CERT UEFI Parser project boards PyPI based deliver. The changes modernize the packaging process, add automated publishing to PyPI, clarify installation instructions, and improve optional GUI support handling. The most important changes are grouped below:
Build and Packaging Modernization
.github/workflows/pyblish.yml) to automate building and publishing the package to PyPI, including support for OIDC-based trusted publishing.pyproject.tomlto use modern build requirements (setuptools_scm,wheel), renamed the package tocert-uefi-parser, added dynamic versioning from git tags, and defined optional dependencies for GUI support via the[qt]extra.Documentation and Installation Improvements
README.mdto clarify installation instructions, including PyPI-based installation, optional GUI dependencies, and updated sample usage. [1] [2]Optional GUI Support Handling
uefi_parser/cmds.pyto import the GUI module only when needed, displaying a helpful message if the optionalqtdependency is missing. [1] [2]