Fix missing builtin glew #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
If no exact init values defined for TAttFill, gStyle configuration is used. So one always have to save fill attributes for such classes
Allows to configure histogram used for axes drawing
Like in TGraph, store histogram which used for axis painting. Resolves problem that GetHistogram or GetAxis methods force recreation of histogram object and updating the pad.
1. Implement for `TPie` 3d, text, title drawing including interactivity 2. Fix - proper paint axis labels on both sides when pad.fTickx/y = 2 3. Fix - paint frame border mode/size from TCanvas
After fixes in JSROOT several tests works better now
There are some changes in gcovr version 8.4 that currently result in incorrect missed lines. Pin to a lower version for the time being. Closes root-project#20047
It was deprecated and scheduled for removal in 70e67f1.
The check for already added variables was redundant, because in the `exportObject()` function we already check if a given argument was already exported, tracking this in a standard map. This drastically reduces performance and memory usage, because the lookup in the JSON itself was very slow and memory hungry, because of some caching that nlohmann-json tries to do when looking up in array collections.
Docu warnings seen in the CI log
Compile macros in advance and use them from srun.C script Avoid usage of rootlogon.C - which automatically involved for all scripts Adjust stlIoTest.ref with actual warnings Remove execute flag for many files Mark as failing readNoLib.C - was fully disabled in Makefile
Windows required correct linking, therefore all depend libs must be linked
…tl test For some reason warning "ROOT does not support variable size array of stl containers" appears for all kind of containers
Seems to be, required on Windows
Use library produced for dictionary directly with executable Use more distinct fixtures names
Replace DEPENDS by fixtures
Remove output from older ROOT versions
This fixes external use of `TGLIncludes.h`: ``` In file included from src/Fireworks/Core/src/CmsAnnotation.cc:4: .../lcg/root/6.39.1-f6b681b05d584b7e93413a4cff8a643d/include/TGLIncludes.h:21:10: fatal error: GL/glew.h: No such file or directory 21 | #include <GL/glew.h> ```
|
A new Pull Request was created by @smuzaffar for branch cms/master/59b8b01860d. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.