Feat/overhaul#38
Merged
Merged
Conversation
Iso.hs: toYoneda->yoneda, toCoyoneda->coyoneda, sieved->indexing, cosieved->coindexing, coswapped->eswapped, coassociated->eassociated, reixes->reixing, recxes->recxing. Add cloneIso.re law to invert doc. Re-export re from Iso.hs operators section. Lens.hs: toPastro->pastro, toTambara->tambara, toClosure->closure, toEnvironment->environment. Add rematching' (existentialized Relens constructor, née costrong). Prism.hs: toPastroSum->pastroSum, toTambaraSum->tambaraSum. Add rehandling' (existentialized Reprism constructor, née cochoice). Setter.hs: reliftedA->coliftedA, reliftedF->coliftedF, reover->coover, scribe->tells, locally->localizes. Fold.hs: toFold0->fold0'. Move viewing (née fromFold0) to View.hs. View.hs: relike->unlike, toProduct->tupling, fromSum->summing. Add viewing from Fold.hs. Combinator.hs: Remove costrong/cochoice (moved to Lens/Prism as rematching'/rehandling'). Keep Arrow re-exports from Import.hs (profunctor arrow operators deferred — name collision with Arrow). Remove Traversal.hs re-exports of arrow operators. Note: cxsetter/ixsetter1/cxsetter1 constructors deferred (need proper Cxoptic implementation).
Drop Control.Arrow (|||),(&&&),(+++),(***) from Import.hs re-exports. Replace all function-level usage with either and fanout (new helper in Import.hs). Arrow instances in Carrier.hs Conjoin use qualified Control.Arrow as A. Fix profunctor-optics-sort Import.hs to import from sub-modules instead of Data.Profunctor.Optic (which is the user-facing front door).
(****) -> (***), (++++) -> (+++), (&&&&) -> (&&&), (||||) -> (|||) Now that Arrow re-exports are removed, these take over the names with the correct profunctor-polymorphic constraints. View.hs: relike -> unlike, toProduct -> tupling, fromSum -> summing.
Lens.hs, Prism.hs, View.hs, Setter.hs: Reorder exports and source code into consistent sections: * Constructors / *** Dual / *** Reversed * Indexed Constructors / *** Coindexed * Optics / *** Dual / *** Reversed * Indexed Optics / *** Coindexed * Operators / *** Dual / *** Reversed * Indexed Operators / *** Coindexed * Reexports Re-add rematching', rehandling', viewing that agents dropped. Hide pastro/tambara from Data.Profunctor.Strong and tambaraSum/ pastroSum from Data.Profunctor.Choice to avoid collision with our renamed versions.
Add H2/H3 sub-sections for Fold0/Fold1 and Traversal0 variants in both the Optics and Operators sections, matching the nesting pattern used in Constructors: * Foo / *** Dual / ** Foo0 / ** Foo1 * Indexed / *** Coindexed / ** Indexed Foo0 Move afolded/acolist to appropriate sub-sections. Separate cofoldMapOf/cofoldOfA into Dual Operators. Move matchOf to Traversal0 Operators. Separate collectOf/cotraverseOf into Dual Operators.
Main types (Foo, Foo0, Foo1) and their indexed variants are all H1. Duals/reversed/coindexed are H2 (one level deeper than parent). Previously duals were H3 which over-indented them in Haddock output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.