Skip to content

Conversation

@MartinS-git
Copy link
Contributor

@MartinS-git MartinS-git commented Dec 12, 2025

Summary

Optimization of spacing and the position of the value row in the select component to match the input field. Also, centered alignment of the icon on the right.
=> Only the "with label" stories are affected.

Changes Made

  • Removed padding from label
  • Added margin-top to value if label appears

Related Issues + Screenshots

Testing Instructions

  1. pnpm i
  2. pnpm TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@MartinS-git MartinS-git requested review from a team and franzheidl as code owners December 12, 2025 07:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2025

⚠️ No Changeset found

Latest commit: b7aac7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2025-12-16 14:02 UTC

TilmanHaupt
TilmanHaupt previously approved these changes Dec 12, 2025
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Screenshot 2025-12-16 at 14 14 49 Screenshot 2025-12-16 at 14 15 00

@MartinS-git MartinS-git merged commit eed4e4b into main Dec 16, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Juno Roadmap Dec 16, 2025
@MartinS-git MartinS-git deleted the select-spacing branch December 16, 2025 14:01
@edda edda removed this from Juno Roadmap Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants