Skip to content

Conversation

@michalkrzyz
Copy link
Collaborator

@michalkrzyz michalkrzyz commented Dec 18, 2025

TODO:

  • refactor (extract methods, avoid multiple insertions of trackers)
  • address TODOs
  • add checks of data in list of patches in database/auto_scan_process_test.go tests
  • e2e tests for new query of list of patches consider adding metadata check
  • add api list patches

On-behalf-of: SAP Michal Krzyz [email protected]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

TODO:
- address TODOs
- add checks of data in list of patches
  in database/auto_scan_process_test.go tests
- e2e tests for new query of list of patches
  consider adding metadata check
- add api list patches

On-behalf-of: SAP Michal Krzyz <[email protected]>
Signed-off-by: Michal Krzyz <[email protected]>
@michalkrzyz michalkrzyz force-pushed the mikrzyz/issue-994 branch 3 times, most recently from 0ec3f48 to 1d30136 Compare December 23, 2025 21:15
@michalkrzyz michalkrzyz marked this pull request as ready for review December 29, 2025 08:13
@michalkrzyz michalkrzyz force-pushed the mikrzyz/issue-994 branch 3 times, most recently from ed6e40c to 602d441 Compare December 29, 2025 09:13
On-behalf-of: SAP Michal Krzyz <[email protected]>
Signed-off-by: Michal Krzyz <[email protected]>
Write failing test, which fails due to creation of 3 patches
for 3 components which disappeared but they have the same version and
service. Expected result is single patch.
@michalkrzyz michalkrzyz marked this pull request as draft December 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants