-
Notifications
You must be signed in to change notification settings - Fork 0
イベント詳細ページとtalksページのUI改善 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- イベント詳細ページ([abbr].astro)にAbout/Event Details/Sessionsセクションを追加 - talksページにoEmbed APIを使用したスライド埋め込み機能を追加(SpeakerDeck, Docswell対応) - talksページにセッション一覧への戻りナビゲーションを追加 - TwitterアイコンをXアイコンに変更(Layout, Footer, talks) - スピーカーのX/GitHubアカウントをクリック可能なリンクに変更 - フッターをシンプル化(Xリンク削除、不要なコード削除) - セッションカードの高さを統一 - 各種パディング調整とレイアウト最適化 - イベントJSONにdescription, venue, dateフィールドを追加 - Conference型にdescription, venue, dateを追加 - プライバシーポリシーに英語版を追加
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
- /history ページを新規作成(CloudNative Daysの歩み) - 2018年Japan Container Daysから現在までの全19イベントを掲載 - 各イベントのロゴ、テーマ、開催日、会場を表示 - アーカイブがあるイベントはカードクリックで詳細ページへ遷移 - イベントページに「トップに戻る」ナビゲーションを追加 - トップページに「CloudNative Daysの歩みを見る」リンクを追加 - Talk説明文のHTMLタグを修正(cnds2025, cndo2021) - data.tsの重複cndo2021エントリを削除 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1570098 to
8d9f50b
Compare
jacopen
requested changes
Nov 26, 2025
Co-authored-by: Kazuto Kusama <[email protected]>
- max-w-3xlで横幅を制限 - 文字サイズをtext-xlに拡大 - leading-relaxedで行間を調整 - 意味の区切りで改行(md以上で表示) - 最後の文にfont-mediumを追加 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- ヘッダーとナビゲーションリンクの干渉を修正(pt-20 → pt-24) - 過去イベントカードのロゴを中央揃えに修正 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
極端に横幅が狭いビューポートでもロゴが縦長に引き伸ばされないよう object-containを追加 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
スマホ表示時にナビゲーションリンクが固定ヘッダーと 重なって押しづらかった問題を解消(pt-16 → pt-24) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Headlineコンポーネントの上部パディングを増加(pt-8 → pt-24) これにより全てのBlog関連ページで一括修正 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
tanayan299
approved these changes
Nov 26, 2025
Contributor
tanayan299
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
変更ファイル
src/pages/[abbr].astro- イベント詳細ページにAbout/Details/Sessionsセクション追加src/pages/[abbr]/talks/[id].astro- スライド埋め込み、戻りナビ、ソーシャルリンク追加src/lib/oembed.ts- oEmbed APIユーティリティ(新規)src/components/Footer.astro- シンプル化(Xリンク削除)src/components/Talk.astro- カード高さ統一src/components/Hero.astro- ロゴマージン調整src/layouts/Layout.astro- TwitterアイコンをXに変更src/data/events/*.json- description, venue, dateフィールド追加src/types/conference.ts- 型定義更新src/pages/privacy.md- 英語版追加Test plan