[vite-plugin] Fix cloudflare:node server dispatch in Vite and Vitest - #15637
Closed
petebacondarwin wants to merge 4 commits into
Closed
[vite-plugin] Fix cloudflare:node server dispatch in Vite and Vitest#15637petebacondarwin wants to merge 4 commits into
petebacondarwin wants to merge 4 commits into
Conversation
Bumps the workerd-and-workers-types group with 2 updates: [@cloudflare/workers-types](https://github.com/cloudflare/workerd) and [workerd](https://github.com/cloudflare/workerd). Updates `@cloudflare/workers-types` from 4.20260702.1 to 5.20260914.1 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md) - [Commits](https://github.com/cloudflare/workerd/commits) Updates `workerd` from 1.20260911.1 to 1.20260914.1 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md) - [Commits](cloudflare/workerd@v1.20260911.1...v1.20260914.1) --- updated-dependencies: - dependency-name: "@cloudflare/workers-types" dependency-version: 5.20260914.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: workerd-and-workers-types - dependency-name: workerd dependency-version: 1.20260914.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: workerd-and-workers-types ... Signed-off-by: dependabot[bot] <support@github.com>
The following dependency versions have been updated: | Dependency | From | To | | ------------------------- | ------------- | ------------- | | @cloudflare/workers-types | ^5.20260911.1 | ^5.20260914.1 | | workerd | 1.20260911.1 | 1.20260914.1 |
🦋 Changeset detectedLatest commit: 622e6e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
@petebacondarwin Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
Contributor
Author
|
I think that this will not be needed once cloudflare/workerd#7357 lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cloudflare/workerd#7306.
Paired runtime change: cloudflare/workerd#7352
This draft fixes
cloudflare:nodeHTTP server dispatch in the Vite and Vitest integrations after Node virtual port tables became Durable Object instance-scoped.Both integrations evaluate user modules inside pinned synthetic runner Durable Objects, but invoke exported handlers from their real I/O contexts. Servers created during module evaluation were consequently registered in the runner actor's table and could not be found by
httpServerHandler()during dispatch. Miniflare now exposes the paired workerd namespace option, and each internal runner service opts in only its explicitly named"singleton"actor. Other actor IDs retain their normal isolated port tables.The branch includes the two dependency-update commits from #15633, because the workerd 1.20260914.1 update exposed the regression. Keeping them here lets the runtime update and compatibility fix land atomically; this draft does not close #15633.
Important
This remains blocked on a workerd release containing the paired runtime PR. With the currently pinned 1.20260914.1 binary, the new schema field is ignored and the two integration regressions fail with the expected missing-port error. Before this is ready to merge, update the pin to the first fixed workerd release and regenerate Miniflare's Cap'n Proto types.
Focused coverage includes Miniflare option conversion and serialization, the existing Vite playground regression, and a new Vitest
SELF.fetch()regression usinghttpServerHandler().